angular/material-start

The app's HTML results in a full-height Sidenav that covers the toolbar instead of staying below it

mtevrst opened this issue · 8 comments

Repo's clone gives this layout instead of the one shown in the readme:

image

Has the behavior of the Sidenav component been changed since this tutorial app was created? What is the way to get the layout shown in the readme?

Is no one addressing the issues in this starter app?

I think the issue comes from angular-material original source...

Check the screenshot of original website:
screen shot 2016-08-11 at 10 48 54 am

But, anyway - you can find other solution. I like how it looks when you adding md-toolbar to slide-nav:
screen shot 2016-08-11 at 3 30 02 pm

Take a look at my example: http://codepen.io/anon/pen/ZOVvWX

@mtevrst - the material-start sidenav should not overlay the content. So good catch!
@Axel186 - the material.angularjs.org sidenav SHOULD overlay the content... that was also by design (as you indicated).

Just checked in Material Guide:

screen shot 2016-08-11 at 7 00 53 pm

Material design Guide

@topherfangio - seems like a worthwhile fix.

@ThomasBurleson Correct me if I'm wrong, but

  • On Desktop - Sidenav should be locked open and show the toolbar above the sidenav
  • On Mobile - Sidenav should act as a standard sidenav which overlays the toolbar

The README never actually shows what should happen on mobile, but I think it is correct as-is.

@mtevrst - Is your sidenav hiding/showing even on desktop? If so, then that is definitely a bug, but should be fixed with the changes I'm making over in the wip/es6-tutorial-updated branch.

Agree with @topherfangio,
if we wanted the sidenav to be toggled on desktop it should be beneath the toolbar for sure, but on mobile it should overlay the toolbar.

will not fix.