md-dialog

Question

md-dialog

jelbourn opened this issue 9 years ago · 54 comments

jelbourn commented 9 years ago

Depends on #113

fxck commented 8 years ago

#3472

Answer 1 · 2016-05-25T18:47:51.000Z

For alpha.6:

Design doc
Basic initial implementation

Answer 2 · 2016-05-26T23:31:20.000Z

This is the component that I'm needing more. :) 👍

Answer 3 · 2016-06-09T17:50:28.000Z

I also need this. Waiting for this. 👍

Answer 4 · 2016-07-13T00:25:40.000Z

We all wait this. @jelbourn, can you merge this early?
I planned my project to use this in alpha.6, but it delayed too much.
Thank you for all your jobs.

Answer 5 · 2016-08-02T12:08:33.000Z

Any estimates on that?

Answer 6 · 2016-08-03T08:34:04.000Z

Is there a design doc somewhere @jelbourn ? Looking at the way the public API looks at the moment(https://github.com/angular/material2/blob/master/src/demo-app/dialog/dialog-demo.ts) I'm afraid it's not gonna be too reactive approach friendly(particularly controlling the dialog state with something like @ngrx/store).

Answer 7 · 2016-08-11T02:36:51.000Z

Hi @jelbourn!

The basic dialog is working already. However, it is not published in npm. May you publish it?

Answer 8 · 2016-08-11T09:32:52.000Z

It's missing some pieces @andvasp, like backdrop. It still more of a prototype than anything that could be released.

Answer 9 · 2016-08-21T13:16:39.000Z

The dialog works, but it appears that there is no way to pass data to the component inside, am I wrong? Like when you call it like this:

this.dialog.open(StandardDialog, config)

Answer 10 · 2016-08-21T14:59:05.000Z

Oh nevermind. For future readers, it's possible to edit the instance of the StandardDialog (custom) class by editing dialogRef like this:

this.dialog.open(StandardDialog, config)
         .then(res => {
            this.dialogRef = res;
            this.dialogRef.componentInstance.title = title;
            this.dialogRef.componentInstance.contents = contents;
         });

Answer 11 · 2016-08-22T07:24:05.000Z

Any news about releasing this? The depending issue is closed (to be splitted further though).

Answer 12 · 2016-08-26T18:56:03.000Z

Adding my +1. This is a big one. Anxiously and excitedly waiting for it. Hope we get an official release soon.

Answer 13 · 2016-09-01T23:31:07.000Z

Remaining work before initial release:

Backdrop (#1041)
Focus trapping

Answer 14 · 2016-09-02T13:17:18.000Z

With #1041 being LGTM would it be possible to get this out on the next release? I know focus trapping is important to ARIA and accessibility but so much is built on md-dialog that it's one big thing keeping us using ng2 or other hacks.. We can just use the PR but I was hoping that we could at least get it on the NPM...

Answer 15 · 2016-09-16T07:59:40.000Z

IT would be great if we can have this in the next release

Answer 16 · 2016-09-16T13:13:43.000Z

@jelbourn Is the intention to allow MdDialog to work with overlay position strategies other than global? I noticed that you're capturing the ViewContainerRef but it seems it currently only being used for maintaining the injector hierarchy, rather than positioning. Would be great if we could place the dialog within a specific container, so that the overlay doesn't have to be global all the time.

Answer 17 · 2016-09-20T12:50:34.000Z

#113 is closed & #1041 is merged.
Both for a while now, what are the news on this?

Answer 18 · 2016-09-28T06:04:44.000Z

i tried MdDialog with rc5 . It gave error

EXCEPTION: Error: Uncaught (in promise): No provider for Token overlayContainer! browser_adapter.ts:82

import {Component} from '@angular/core';
import {MdDialog} from '@angular2-material/dialog/dialog';
import {Overlay} from '@angular2-material/core/overlay/overlay';
@component({
moduleId:__moduleName,
selector: 'iPopup',
templateUrl: 'iPopup.html',
styleUrls: ['iPopup.css'],
directives: [MdDialog],
providers:[Overlay]

})

Answer 19 · 2016-10-07T11:40:07.000Z

Is there a close method on the current released alpha.9-3?
As I see here:
https://github.com/angular/material2/blob/master/src/lib/dialog/dialog.ts

There's no close method but on the other hand things that are in comments marked as todo (like close on esc etc) works.

Answer 20 · 2016-10-07T18:32:58.000Z

Close is on the MdDialogRef that you get back from opening it.

Answer 21 · 2016-10-12T23:53:39.000Z

You can check the demo code here: https://github.com/angular/material2/tree/master/src/demo-app/dialog

Answer 22 · 2016-10-17T19:12:48.000Z

Hi, When do you plan to release md-dialog in npm?

Answer 23 · 2016-10-17T19:28:55.000Z

@cpena material2 is now found at @angular/material on npm. md-dialog is included in that package.

Answer 24 · 2016-10-17T19:34:50.000Z

Is the NPM version up to 9 yet? NPM versioning looks like its still back
at alpha.8-2

On Mon, Oct 17, 2016 at 12:29 PM, Noah Wood notifications@github.com
wrote:

@cpena https://github.com/cpena material2 is now found at @angular/material
https://www.npmjs.com/package/%40angular%2Fmaterial on npm. md-dialog
is included in that package.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACv1Dd0Nv_jbS0swfqFzk8WkR33JxRFBks5q08yRgaJpZM4HkX5c
.

Answer 25 · 2016-10-17T19:44:21.000Z

It's on alpha.9-3 now.

Answer 26 · 2016-10-17T19:50:58.000Z

@goelinsights Yes. The npm package at @angular/material is at 2.0.0-alpha.9-3. The old package at @angular2-material is the one at alpha-8.2.

Answer 27 · 2016-10-19T14:52:14.000Z

What webpack version should I use to run this dialog in my project?

Answer 28 · 2016-10-19T15:39:14.000Z

@Ranguro you can use any. Just use @angular/material 2.0.0-alpha.9-3 and up. Try StackOverflow for more support on such questions though ;)

Answer 29 · 2016-10-21T09:57:41.000Z

Is it possible to passing data to the component? via @input() or something else?

Answer 30 · 2016-10-21T23:46:03.000Z

I have material 2.0.0-alpha.9-3 and trying to use md-dialog I get an error:

`polyfills.bundle.js:7625 Unhandled Promise rejection: Template parse errors:
'md-dialog' is not a known element:

If 'md-dialog' is an Angular component, then verify that it is part of this module.
If 'md-dialog' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the '@NgModule.schemas' of this component to suppress this message. ("

[ERROR ->] Test

"): CompanyComponent@32:0 ; Zone: ; Task: Promise.then ; Value: Error: Template parse errors:(…) Error: Template parse errors:
'md-dialog' is not a known element:

If 'md-dialog' is an Angular component, then verify that it is part of this module.
If 'md-dialog' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the '@NgModule.schemas' of this component to suppress this message. ("

[ERROR ->] Test

"): CompanyComponent@32:0
at TemplateParser.parse (http://localhost:35606/dist/vendor.bundle.js:8707:22)
at RuntimeCompiler._compileTemplate (http://localhost:35606/dist/vendor.bundle.js:17029:54)
at http://localhost:35606/dist/vendor.bundle.js:16951:86
at Set.forEach (native)
at compile (http://localhost:35606/dist/vendor.bundle.js:16951:50)
at ZoneDelegate.invoke (http://localhost:35606/dist/polyfills.bundle.js:7473:29)
at Zone.run (http://localhost:35606/dist/polyfills.bundle.js:7366:44)
at http://localhost:35606/dist/polyfills.bundle.js:7732:58
at ZoneDelegate.invokeTask (http://localhost:35606/dist/polyfills.bundle.js:7506:38)
at Zone.runTask (http://localhost:35606/dist/polyfills.bundle.js:7406:48)
at drainMicroTaskQueue (http://localhost:35606/dist/polyfills.bundle.js:7638:36)consoleError @ polyfills.bundle.js:7625_loop_1 @ polyfills.bundle.js:7652drainMicroTaskQueue @ polyfills.bundle.js:7656
polyfills.bundle.js:7627 Error: Uncaught (in promise): Error: Template parse errors:(…)consoleError @ polyfills.bundle.js:7627_loop_1 @ polyfills.bundle.js:7652drainMicroTaskQueue @ polyfills.bundle.js:7656`

Answer 31 · 2016-10-21T23:47:40.000Z

MdDialog is a service, not a @Component

Answer 32 · 2016-10-22T00:14:30.000Z

A quick example code would be most helpful

Answer 33 · 2016-10-22T00:22:30.000Z

Don't have docs for it yet, but the unit test might be helpful:
https://github.com/angular/material2/blob/master/src/lib/dialog/dialog.spec.ts#L50

Answer 34 · 2016-10-22T06:49:17.000Z

I still think it should be both component and service. Both have use cases, and for me, having global state management, I'd prefer component 90% of time.

Answer 35 · 2016-10-22T07:10:43.000Z

Looks like someone wrote up an example just today: http://stackoverflow.com/a/40185852/550975

Answer 36 · 2016-10-22T10:14:58.000Z

There is an example here in the demo-app in this repository. https://github.com/angular/material2/tree/master/src/demo-app/dialog

Answer 37 · 2016-10-23T22:34:21.000Z

@serjster, you can read this article as well https://medium.com/@tarik.nzl/making-use-of-dialogs-in-material-2-mddialog-7533d27df41

Answer 38 · 2016-10-24T07:23:11.000Z

@reinos You can pass in the config parameters I guess your object and you can use them then.

Answer 39 · 2016-10-27T01:32:00.000Z

Closing this issue now and going to track remaining work through separate issues

Answer 40 · 2016-12-16T02:48:35.000Z

Is there a way to make the content scrollable within the dialog?

Answer 41 · 2016-12-16T05:04:22.000Z

@nak411, try with css.

Something like:

md-dialog-container {
    overflow: auto;
    height: 300px;
}


or perhaps similar to that on your component.

Answer 42 · 2017-03-08T07:28:11.000Z

is there any way to pass data to dialog ?

Answer 43 · 2017-03-08T07:29:11.000Z

https://github.com/angular/material2/issues?utf8=%E2%9C%93&q=passing%20data%20

Answer 44 · 2017-03-08T16:49:26.000Z

I want to add custom css class to “.mat-dialog-container” to customize it’s background because I have more than one dialog , there is no class property in MdDialogConfig class ?!

Answer 45 · 2017-03-08T17:40:05.000Z

I think if there is class property in MdDialogConfig will be much easier , thanks @fxck anyway .

Answer 46 · 2017-03-10T12:22:52.000Z

How can I notify to parent from dialog?

Answer 47 · 2017-04-01T00:54:51.000Z

@ermarkar Have you got any idea ? I wanna know that too...

Answer 48 · 2017-04-01T17:46:35.000Z

@shuzootani
Here is the answer
http://stackoverflow.com/questions/42717508/how-to-communicate-from-angular-material2-dialog-to-its-parent

Answer 49 · 2017-04-03T01:13:29.000Z

If a dialog is set to allow dismissal by clicking outside the dialog is it possible to prevent its dismissal, for example in the case where the dialog contains a form which has not been saved - in which case I'd want to ask the user first if they want to save it?

Answer 50 · 2017-04-03T13:12:02.000Z

@stuarthallows #3460

Answer 51 · 2017-04-13T12:27:30.000Z

Hi why after upgrade to beta.3 I can not see MdDialogRef.options anymore? I was passing some data this way and now after upgrading to angular 4 and beta 3 of material I do not know how to pass.

Answer 52 · 2017-04-13T12:28:58.000Z

https://github.com/angular/material2/issues?utf8=%E2%9C%93&q=dialog%20data

Answer 53 · 2019-09-05T15:02:33.000Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}