@delon/abc
mgechev opened this issue · 3 comments
mgechev commented
ERROR in There is no appropriate source code format in '/Users/mgechev/Projects/ngcc-validation/delonabc-ngcc/node_modules/date-fns/add_seconds' entry-point.
petebacondarwin commented
mgechev commented
@petebacondarwin looks like this is still failing:
ERROR in The target entry-point "@delon/abc" has missing dependencies:
- date-fns/add_seconds
Although it looks like a problem with the package itself? I checked date-fns
and didn't find add_seconds
there.
petebacondarwin commented
Despite not declaring them as a dependency, this library does try to import the date-fns
library. See https://github.com/ng-alain/delon/blob/master/packages/abc/count-down/count-down.component.ts#L2-L3
But they use some weird non-peer dependency whitelisting: https://github.com/ng-alain/delon/blob/master/packages/abc/ng-package.json#L11
And unfortunately @delon/abc
needs a v1.x version of date-fns but we are installing 2.x version because of @nebular/date-fn
, which is why the import is not being found...