Some issues in dccd

Question

Some issues in dccd

Opened this issue 10 years ago · 2 comments

vicb commented 10 years ago

this code has some issues:

hashCode is a property of Objects in Dart - not sure if it's applicables to JS,
not all modes have _MODE_NAMES (10, 11)

Answer 1 · 2014-06-10T19:10:13.000Z

Thanks @vicb

Answer 2 · 2014-06-10T19:29:18.000Z

@EisenbergEffect I think I mentioned this before, but the NOTIFIED and NOT_NOTIFIED modes are more like boolean flags, these probably shouldn't live in mode, but I don't think this ever was justified. Anyways, I'm not going to add names for them right now, but that should probably be cleaned up or at least explained more clearly.