Validation for email field in Signup form

Question

Validation for email field in Signup form

Closed this issue a year ago · 7 comments

Bug
During signup, entering only "mail@a" as the email address is incorrectly accepted. This email lacks the expected format with a domain name and top-level domain, making it invalid.

Solution
This can be fixed with ZOD validation library.

Screenshots

This get's accepted and I got signedup!

Answer 1 · 2023-12-18T02:27:46.000Z

@ani1609 @niladrix719 Please assign this issue to me. I am learning express and learned about ZOD validation library, so I think I can fix this bug for KWoC.

Answer 2 · 2023-12-18T06:56:51.000Z

@Anuj-Gill we have decided to shift the authentication process to firebase authentication where the users will be sent a verification link over email. Will your idea be helpful in that scenario?

Answer 3 · 2023-12-18T16:35:55.000Z

@ani1609 I believe yes, because we can use ZOD to pre-validate the email address format before sending it to Firebase for verification. This can improve server efficiency by catching obvious errors beforehand.

Answer 4 · 2023-12-18T16:39:37.000Z

@Anuj-Gill sure go ahead

Answer 5 · 2023-12-22T06:56:42.000Z

@Anuj-Gill any update?

Answer 6 · 2023-12-22T17:46:00.000Z

@ani1609 I have created a PR. Please have a look.

Answer 7 · 2023-12-24T07:41:05.000Z

@Anuj-Gill done