ankane/lockbox

Migrating Existing Files with Active Storage

ankane opened this issue ยท 5 comments

Overall, I'm happy with the approach and haven't seen issues while testing, but it'd be great if others could confirm it works for them before taking off the experimental label. Please try it out and share your experience below (even if it's just a few words).

I gave this a try on a production but pre-release product I'm working on. The migration ran fine and had no errors, but I did try to download a file while the migration was running and got invalid data. Opening the file worked fine before and worked after, and there were no application errors from it, so unfortunately I have nothing that could lead to a repro much less a fix.

(Given the pre-launch status, I wasn't being quite as careful as one could be, so it's also totally possible I messed something up along the way. The one thing I'm sure of is that, once the migrate command was finished, the exact same production deployed code produced the uncorrupted file.)

Hey @bmulholland, thanks for sharing! I'm not exactly sure how that would happen (maybe the migrating: true code hadn't gone live when migrating started?). Anyways, will wait to see if any there are similar reports.

I did a migration in production (private beta, only ~200 files to migrate), it went well, even during the process I did not have errors when I try to view some files.

Thanks for your amazing job btw!

Thanks @skelz0r!

Taking off the experimental label since it's been over 10 months. Thanks again for the feedback @bmulholland and @skelz0r!