anolilab/unplugin-favicons

Nuxt configKey is wrong, error on run, and doesn't run on dev process

Closed this issue · 5 comments

Pre-Checks

Describe the bug

  1. your Nuxt module configKey is set to openapi-jsdoc-compiler instead of faviconsPlugin which you've used for other frameworks/builders. See the Nuxt Google Fonts module for an example of Nuxt's two different config formats, one of which uses this configKey as a key.

  2. When using this config, and running pnpm build, I get the error ERROR Nuxt Build Error: [@anolilab/unplugin-favicons] The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

'openapi-jsdoc-compiler': {
	logo: '/assets/logo.svg', // or png produces the same error
	appName: 'redacted',
	developerName: 'redacted',
	developerURL: 'redacted',
	background: '#bada55',
	theme_color: '#c0ff33',
	icons: {
		windows: false,
		yandex: false
	}
}
  1. Nothing happens at all when running pnpm dev, which is the local development server. It would be nice if the module worked with this to preview the results during the standard dev process instead of pnpm build which is the production build process.

I'm sorry I haven't followed the bug report format, I'm working on a project and have limited time. This looks like a great project though and you should submit it to the Nuxt modules directory!

As an aside, unplugFavicon would make a great module name instead of the more generic faviconsPlugin.

Minimal reproduction code

No response

Additional Context

No response

Environment Info

sh: envinfo: command not found

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

pnpm

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Hey @gridsystem, thank you for the bug report :)

Point 1 and 2 will be fixed with #51

For point 3, need a bit more time to find a good way to do it

version 1.0.4 will have a working nuxt intigration :)

This issue has been automatically marked as stale because it has been open for 21 days with no activity. It will be closed in 7 days if no further activity (Remove label or comment) occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of this project. 🙏

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.