anomic30/Storz

Lint: Add pre-commit hook

Closed this issue · 3 comments

ezehlivinus commented

The project needs a pre-hook commit that will run to lint and format the change to the project before it gets committed to git.

Given that linting and formatting have been configured for the project, setting up a pre-commit hook will help lint and format changes on committing.

ezehlivinus commented

@anomic30 Please assign this to me and update the necessary labels.

There is a problem with this:

  1. husky or lint-style require that .git/, package.json are all same directory
  2. Because the Storz/ folder has the .git/ folder and no package.json file, this may be difficult to work

git commit is best executed where .git/ exists, while npm/yarn is also best executed where package.json exist.

What do you think?

anomic30 commented

@ezehlivinus, So we need to separate our client and server into two different repos. Currently, we won't be able to do this, can consider it later for sure. Meanwhile, I am closing this issue.

ezehlivinus commented

@ezehlivinus, So we need to separate our client and server into two different repos. Currently, we won't be able to do this, can consider it later for sure. Meanwhile, I am closing this issue.

Okay fine...