anshumanv/ongaku

Merge the preferences button (Improve UI as well) and info button

anshumanv opened this issue · 11 comments

Currently, we have preferences and info button aligned side by side. Let's merge them into a single button called settings, and by clicking the button we have foldable sections to preferences and keycodes each, a good example is in http://openings.moe (Menu button) we need something along those lines.

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This issue is for enhancement/bug fixing.
  • This issue is an addition to JSON database.
  • I have gone through Contribution Guidelines.
  • Assign this issue to me.

Are you sure?

In my opinion the way you have the buttons set looks good and is a quick access which is better.

In that case, let's improve the keycode info button, I don't like the current button, it's buggy and not well modeled.

Agree

In that case, please improve the info button UI and send a PR. 😄

What about making it behave similar to the preference button? or do you have something else in mind?

@OuKevin let's make it similar to the preferences button (with improved UI), please send a PR.

Remove Hacktoberfest label

Help still needed?

Sure, please feel free to send a PR @Shiroraven 😄

@anshumanv is there any way to contact you to discuss what changes need to be made to the UI, because from reading the issue alone i don't quite understand.

Sure @Shiroraven you can contact me on telegram, my handle - @anshumanv