ansible-collections/vmware.vmware_rest

Support using module_defaults

Yannik opened this issue · 7 comments

Yannik commented
SUMMARY

The non-rest vmware collection supports module_defaults, due to its action_groups config in https://github.com/ansible-collections/community.vmware/blob/main/meta/runtime.yml.

It would be great if vmware_rest would support this too.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

meta

I think this is a valid feature request. However, the modules are generated (originally with with vmware_rest_code_generator but we're working on using ansible.content_builder) I wonder if this is something that we should do manually or something we could generate also.

@alinabuzachis @GomathiselviS What do you think?

I think this has already been requested: #361

Yannik commented

@mariolenz You are right, #361 is requesting the same thing.

I'll leave it up to you whether to continue the discussion there or here.

Since action_groups are defined in meta/runtime.yml and this file seems to be generated by ansible.content_builder, I think this has to be implemented there. I've opened a feature request to implement this: ansible-community/ansible.content_builder#75

Therefore I'll close this issue for now. If you think I'm wrong closing it, feel free to open it again 😃

Yannik commented

Makes sense, thanks @mariolenz

Yannik commented

@mariolenz A fix for this was merged on Jan 10th here: ansible-community/ansible.content_builder#78

..but there are still no action groups in vmware_rest today: https://github.com/ansible-collections/vmware.vmware_rest/blob/main/meta/runtime.yml

Is there anything that still needs to be done here?

Is there anything that still needs to be done here?

Yep, someone has to re-generate the collection. @alinabuzachis Do you plan to do this?

Alternatively, I've opened #475 as a quick'n'dirty fix. However, even if this is merged I think it's important to release it, too. I consider this a new feature (not a bugfix) so 3.1.0?