ansible-community/community-topics

Removed collection servicenow.servicenow back in Ansible 8

mariolenz opened this issue · 5 comments

mariolenz commented

Summary

We have decided to remove the deprecated collection servicenow.servicenow from Ansible 7. Actually, we have removed it from Ansible 7:

https://github.com/ansible-community/ansible-build-data/blob/816c88e2b06b5fbfdc54ef6d8eab0162945bf6f3/7/CHANGELOG-v7.rst#L4861-L4864

However, it's back in Ansible 8:

https://github.com/ansible-community/ansible-build-data/blob/816c88e2b06b5fbfdc54ef6d8eab0162945bf6f3/8/ansible.in#L99

And it turns up as added in the changelog:

https://github.com/ansible-community/ansible-build-data/blob/816c88e2b06b5fbfdc54ef6d8eab0162945bf6f3/8/CHANGELOG-v8.rst#added-collections

The collection was part of 8/ansible.in since the beginning: ansible-community/ansible-build-data#181.

But since it had been already removed from 7 I think this has been a mistake. I suggest to remove it ASAP so it won't be part of 8.2.0 anymore.

Or can someone remeber that we decided to add it again?

Andersson007 commented

i don't remember any decisions about adding it back and searching in open/closed topics doesn't show anything related. strange
if no objections, let's remove it? Objections? (i don't think we should wait for them for longer than next week)
@mariolenz thanks for spotting this!

mariolenz commented

I've created PR ansible-community/ansible-build-data#254 to address this. If nobody objects, we can merge it next week. Otherwise, we'll just close it unmerged.

  • 👍1
felixfontein commented

Adding it back was clearly a mistake. But we MUST NOT remove it from 8.x.0, but from 9.0.0. Removing it earlier is a breaking change.

mariolenz commented

Well, I considered it a bug that it's part of Ansible 8. But of course we can wait until 9.0.0.

mariolenz commented

Closing since ansible-community/ansible-build-data#254 has been merged.

  • 👍1