ansible-lockdown/UBUNTU22-CIS

A value for var: *container_vars_file* is not defined in this role

Closed this issue · 2 comments

Question
In other roles, like RHEL9, I noticed defining:

  1. in defaults/main.yml file a specific value for container_vars_file var
  2. in vars/is_container.yml the actual values for different variables needed for dealing with a container
  3. in tasks/main.yml the actual handling of dealing with a container.

In this role(UBUNTU22), I noticed there's only an "is_container: false" statement in defaults/main.yml file, but:

  • the "container_vars_file" var is missing(point 1) above)

  • the point above seems fair, as also there's no file in "vars/" dir to be used for dealing with container variables.

  • - my concern is related to the fact that point 3) above seems to be the only one present in Ubuntu22: there's a task dealing with container-handling, using a reference to container_vars_file which is NOT DEFINED in this repository.

Is this a small omission or I missed something here for Ubuntu22 role?

Environment (please complete the following information):
N/A

hi @ipruteanu-sie

Thank you for raising this, you are correct it is an oversight, while we don't actually support containers officially we do try and allow people to work on this. I am adding the required variable and an initial container variable file to an upcoming PR i will be raising.
Any feedback on this would be great.

Many thanks

uk-bolly

I believe that this issue has been addressed and the fix merged?
I will close this issue, please feel free to reopen or raise a new one if this particular problem still exists.

Many thanks

uk-bolly