ansible-middleware/keycloak

I introduced a bug in the parameter validation which causes the role to fail

Closed this issue 3 months ago · 1 comments

InfoSec812 commented 3 months ago

SUMMARY

TASK [redhat.rhbk.rhbk : Verify valid parameters for download credentials when specified] ******************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: NoneType: None
fatal: [192.168.100.180]: FAILED! => {"changed": false, "msg": "Invalid options for ansible.builtin.fail: when"}

caused by :

- name: "Verify valid parameters for download credentials when specified"
  ansible.builtin.fail:
    msg: >-
      When JDBC driver download credentials are set, both the username and the password MUST be set
    when:
      - rhbk_jdbc_download_user is undefined and rhbk_jdbc_download_pass is not undefined
      - rhbk_jdbc_download_pass is undefined and rhbk_jdbc_download_user is not undefined

The when clause should be "or" instead of "and"

ISSUE TYPE

Bug Report

ANSIBLE VERSION

COLLECTION VERSION

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

guidograzioli commented 3 months ago

wow we really need to see how this slipped thru CI validation tests!