ansible/ansibullbot

"Files identified in the description" links to file that no longer exists

n-st opened this issue · 4 comments

n-st commented

In ansible/ansible#70294, the bot reports:

Files identified in the description:

(Nevermind that this was an incorrect guess.)

At the time the bot posted this, the file github_issue.py no longer existed in that location, so the link resulted in a 404.

The file did exists previously, e.g. in the stable-2.9 branch, so perhaps the bot is operating on an outdated clone of the repository?
Or it is working on a different branch and shouldn't make assumptions (and links) for the devel branch?

We still need to identify components that were moved into collections in order to mark such issues with the needs_collection_redirect label and potentially auto-close them with a message informing where to file that particular issue.

n-st commented

Would it be possible to add a note to the bot's output in those cases, to avoid causing confusion about the broken link? Maybe even a link to a pre-collections branch where the file still existed?

That information is more or less already present via labels bot added to the issue, no?

n-st commented

I didn't see anything that would indicate that the dead link is not a bug, so I would say no.