ansman/git-praise

Just replace with config?

neerolyte opened this issue · 3 comments

Just thought I'd mention you could do this with config:

git config --global alias.praise blame

That's awesome, though then we couldn't do custom things if we wanted to.

Fair enough, but I'm not sure what you'd want to customise.

I should probably at least point out that you're not currently preserving the exit status (which the config alias would do).

You probably either want sh -e on the #! line or set -e on the next:

$ man sh | grep -A1 -- '-e errexit'
           -e errexit       If not interactive, exit immediately if any untested command fails.  The exit status of a command is considered to be explicitly tested if the command is used to control an if, elif, while, or until; or if the command is the left hand
                            operand of an “&&” or “||” operator.

That way if blame exits ungracefully, so will praise.

Mostly docs and commands I guess. I've added the the -e flag in 66c2cfd