Factory issues with kotshi 2.0-rc1

Question

Factory issues with kotshi 2.0-rc1

mjmacleod opened this issue 6 years ago · 9 comments

Using kotshi:1.0.6 the following works

@KotshiJsonAdapterFactory
abstract class ApplicationJsonAdapterFactory : JsonAdapter.Factory {
    companion object {
        val INSTANCE: ApplicationJsonAdapterFactory = KotshiApplicationJsonAdapterFactory()
    }
}
...
moshi = Moshi.Builder().add(ApplicationJsonAdapterFactory.INSTANCE).build()

If I upgrade to kotshi:2.0-rc1 it no longer works Expression 'KotshiApplicationJsonAdapterFactory' of type 'KotshiApplicationJsonAdapterFactory' cannot be invoked as a function. The function 'invoke()' is not found

If I follow the latest in the README:

@KotshiJsonAdapterFactory
object ApplicationJsonAdapterFactory : JsonAdapter.Factory by KotshiApplicationJsonAdapterFactory
 ...
 moshi = Moshi.Builder().add(ApplicationJsonAdapterFactory).build()

This also doesn't work Unresolved reference: KotshiApplicationJsonAdapterFactory

Is there something I'm missing here?

Answer 1 · 2019-03-26T09:20:27.000Z

Kotlin version is 1.3.21
Moshi version is 1.8.0

Answer 2 · 2019-03-26T11:04:33.000Z

Man, I had hoped kapt would be better with this now. Anyway, the generated factory is an object in 2.0 so just remove your parentheses in the first example and that will still work

Answer 3 · 2019-03-26T11:38:40.000Z

Oh weird, you are right that works (removing parenthesis) even though the IDE flags it as an error and displays it red as a result.

Answer 4 · 2019-03-26T11:49:53.000Z

The weird part is that if you switch to the delegate approach now it will probably work

Answer 5 · 2019-03-26T11:56:51.000Z

I do seem to get the same error still now if I switch to the delegate approach after successfully building first with the original approach, anyway the first approach is fine so I'll just stick to that - thanks.

Answer 6 · 2019-03-26T13:04:34.000Z

Ok, glad you got it to work. Let me know if you find any other issues.

Answer 7 · 2019-03-26T19:55:18.000Z

@JakeWharton Do you have any idea of why this keeps happening? Even with delegates Kapt seems really flaky.

I'm considering going for a reflective factory. That way you could easily use reflection for debug.

Answer 8 · 2019-04-08T15:48:20.000Z

Is there a kapt bug for it? I suspect that the stub generator is just failing on the missing reference instead of ignoring it.

Answer 9 · 2019-04-08T15:49:20.000Z

I haven't found one and I'm not sure what to write if I were to file one since I can't reproduce it consistently.