Generated factory type should be package scoped

Question

Closed this issue 7 years ago · 4 comments

Hopefully this doesn't prevent consumers from other packages from seeing the JsonAdapter.Factory interface...

Answer 1 · 2018-02-11T00:08:10.000Z

I think this will prevent the code from compiling on Kotlin, the subclass needs to have the same or tighter visibility.

Answer 2 · 2018-02-11T00:10:28.000Z

Maybe you could do this instead?

@KotshiAdapterFactory
object MyFactory : JsonAdapter.Factory by KotshiMyFactory.INSTANCE

Answer 3 · 2018-02-11T00:11:21.000Z

Ah, my usage is internal which is probably why it worked when I made the change.

I wonder if

@KotshiJsonAdapterFactory
object MyJsonAdapterFactory : JsonAdapter.Factory by KotshiMyJsonAdapterFactory

would work...

Biggest problem is that Kotlin won't recognize the Java as being an object so you'd be forced to do by KotshiMyJsonAdapterFactory.INSTANCE

Answer 4 · 2018-02-11T00:12:51.000Z

Hah, yep. Downside of that approach, though, is that you get two instances instead of one. It's fine as-is.