Use 'native' poetry features for 'pyansys-advanced' poetry option?
Opened this issue · 4 comments
Description of the feature
When instantiating pyansys-advanced with poetry as a build tool, it still produces the requirements/requirements_*.txt files. My (limited) understanding of poetry is that the native way of doing this would be adding extra dependencies, which can be installed with e.g. poetry install -E docs.
The role of the requirements_*.txt files would then be taken over by the poetry.lock file.
Similarly, the installation instructions refer to manually creating a virtualenv, whereas poetry includes virtualenv management. FMPOV, documenting the use of the "native" poetry commands gives a better user experience.
If there's a specific reason why the native poetry commands don't work well, I'd be very interested to know it.
Tagging @jorgepiloto for comment.
In case someone wants to take a crack at this, I have an updated "instantiated" template in a private repo. Ping me for access.
@jorgepiloto @akaszynski if you agree on the general approach, I could also try merging back my changes myself. Will need a bit of hand-holding w.r.t. how the files are split up between common parts and specific templates, though.
Pinging @jorgepiloto for a followup with this.
Thanks for opening this @greschd and for pinging me, @akaszynski.
I agree that poetry native features should be used if the [poetry] option is selected when baking a template. I think I experience some problems when using those in the past, but if those still apply is something we need to investigate as you say, Dominik.
If you already made some changes locally, it would be nice if you could open a PR for merging those. I will help you if required.
Related with #3.