antfu-collective/vitesse-webext

refactor/mv3 contentScript HMR is not work

xlzy520 opened this issue · 8 comments

xlzy520 commented

Describe the bug

code

image

page

image

if refresh the ext
image

page is ok.
image

Reproduction

vitesse-webext/src/contentScripts/index.ts

System Info

System:
    OS: macOS 11.7.1
    CPU: (8) arm64 Apple M1
    Memory: 96.77 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Edge: 103.0.1264.71
    Firefox: 106.0
    Safari: 14.1.2

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
hakadao commented

SAME, and my solution was to install the Extensions Reloader. After making changes to the extension files, I would on click the Extensions Reloader button and refresh the page to ensure the changes would be applied.

zf1998 commented

@xlzy520 Has the problem been resolved now? I also encountered the same problem.

tmkx commented

refactor/mv3 is deprecated, please use main branch

louisremi commented

@tmkx as far as I can tell, HMR ins't working for content script on the main branch :-/

  • 👍3
tmkx commented

I think it's hard to make HMR working for contentScript? for example, the script is injected to a webpage(.e.g https://example.com)，when we try to connect with vite server(protocol http), it should meet a "mixed content" error

tshemeng commented

@tmkx But plasmo did it.

  • 👍2
yunsii commented

@tmkx as far as I can tell, HMR ins't working for content script on the main branch :-/

It is still not work for now.

yunsii commented

@tmkx But plasmo did it.

After I tested, plasmo seems not supported content scripts TRUE HMR, related code: consolidateUpdate(), it reload page roughly, but chrome-extension-tools supported.

ref: PlasmoHQ/plasmo#755

  • ❤️2