antirez/neural-redis

Unexpected behaviour with NR.OBSERVE in multi

Opened this issue · 3 comments

stockholmux commented

NR.OBSERVE doesn't reject the wrong number of arguments when in a MULTI. Here I'm running NR.OBSERVE with no arguments.

> MULTI
OK
> NR.OBSERVE
QUEUED
> NR.OBSERVE
QUEUED
> EXEC
1) (error) ERR wrong number of arguments for 'nr.observe' command
2) (error) ERR wrong number of arguments for 'nr.observe' command

I would expect that if you run NR.OBSERVE you would receive an immediate error and/or trigger an EXECABORT when running the EXEC command.

itamarhaber commented

This is actually an issue of modules API itself because this is the behavior of any module command. There's also a difference in how COMMAND GETKEYS responds for core and module commands if passed w/ incorrect arguments.

stockholmux commented

@itamarhaber So, am I reading that this is the expected behaviour? Or will a fix to the modules API make module commands behave the same way as the in-built commands?

itamarhaber commented

The latter, but there isn't a relevant open issue - perhaps you should migrate this issue to the Redis repository