CSS in HTML Files
Closed this issue · 5 comments
HTML Files will need to be scrubbed of any CSS unless specifically needed.
This is an flow on affect of the migration.
CSS is provided by the Wiki.js platform itself, CSS is not needed in the HTML for each page.
I can take this one
Hi CMDRMgram, wanted to clarify a few points regarding 'specifically needed' before I merge and submit a PR.
- Wiki.js doesn't have out-of-the-box CSS for iframe embeds, they pop up as small as possible. Are you planning on using the wiki.js CSS override to manage content like that (or custom per page, etc.), or should I add the inline CSS back?
- Inline CSS currently required for thargoid specs table, may be more trouble to fix up in wiki.js than it's worth. I see that there's an optional table module that can be enabled but that's something the site admin would have to do.
contains iframes:
basic-combat-guide.html
buildrepository.html
cold-orbiting.html
mini-tot-calculator.html
synthesiscalculator.html
guardianunlocks.html*
large-ship-guide.html*
*These two contained non-functional oembed links. I replaced that code to use iframes.
@WillHof I can setup the Global CSS overrides for the Video embeds, this will make it easier to standardise the layout of embedded videos across the wiki. Something like this:
Would you know how to make some CSS for this that I can add to the Global CSS Override? ie: 66% width, centered
I have created a new issue for the CSS in the Thargoid Spec Table as I believe this entire table needs an overhaul. Lets ignore it for now and we can have a look at the table module if this will be sufficient.
@WillHof I can setup the Global CSS overrides for the Video embeds, this will make it easier to standardise the layout of embedded videos across the wiki. Something like this:
Would you know how to make some CSS for this that I can add to the Global CSS Override? ie: 66% width, centered
I have created a new issue for the CSS in the Thargoid Spec Table as I believe this entire table needs an overhaul. Lets ignore it for now and we can have a look at the table module if this will be sufficient.
I'm not the best at CSS; but centered the iFrame and downscaled it. Reducing the vertical padding further starts clipping into the iFrame, as if it was still sized at 100%. It doesn't look too bad but the vertical gaps should be shorter, not sure how to fix it.
All good, I'll work the the video CSS later, great work on this issue. I've committed the changes. Let's check out if it's working as intended.