bug: when some chars in url that cant be in path it result in error

Question

bug: when some chars in url that cant be in path it result in error

aldarund opened this issue 5 years ago · 5 comments

Error: C:\Dev\PycharmProjects\StampinUp.Ordering.Frontend.memento-cache\https___qa-ordering-backend-stampinup-qa\get__en-us_products?-6d13f02e3ed5c6b7e9d0b8210aa77464b7900949 contains invalid WIN32 path characters.
at Object.mkdirs (C:\Users\aldarund\AppData\Roaming\npm-cache_npx\17460\node_modules@antoinechalifour\memento\node_modules\fs-extra\lib\mkdirs\mkdirs.js:18:22)

Answer 1 · 2019-08-27T07:31:03.000Z

Hi @aldarund , thanks for reporting the issue.

I found this about invalid characters: fs-extra source code, Windows rules for directory names.

I can fix it but won't be able to try it on an actual computer as I don't have access to a Windows machine.

Answer 2 · 2019-08-27T11:38:21.000Z

if u create PR, i can test it locallt

Answer 3 · 2019-08-31T19:27:39.000Z

Hi @aldarund , I just opened #57 . It would be great if you could test it locally and give me some feedback :)

Answer 4 · 2019-09-01T13:22:05.000Z

I just release 1.3.1-alpha.0 which includes the fix. You may try it using: npx @antoinechalifour/memento@1.3.1-alpha.0

Let me know if it works!

Answer 5 · 2019-09-09T11:45:36.000Z

@antoinechalifour just got to it. 1.5 seems to work fine