antonioalmeida/ditado-api

Add ditados.json format validation

Closed this issue · 4 comments

antonioalmeida commented

Implement some form of static validation on the ditados.json file that is ran in PRs and blocks merges if there are problems

creativenull commented

Hey there!

Can I try out this one if you assign it to me?

I'm thinking of creating a json schema file and validate it against the json file.

antonioalmeida commented

Go ahead! Feel free to open an initial PR and I'll assign

  • 👍1
antonioalmeida commented

Hey @creativenull , seems like we need to move up the require statements in the ditados.test.js file, can upon a follow up PR?

See the failed build here

creativenull commented

Oh sorry, completely missed to run lint :/

I'll make a separate PR for the fix