antonmedv/codejar

missing line numbers

Closed this issue · 8 comments

julianpoemp commented

as far as I can see linenumbers.js was deleted in a previous commit. Was this intended? Is there any plan to add support for line numbers again?

antonmedv commented

Nope. I kinda disliked this line-numbers implementation. I think line numbers can be easily added by third-party packages like codejar-linenumbers.

julianpoemp commented

@antonmedv I was just wondering because I couldn't find any information or braking change about linenumbers.

Where can I find the codejar-linenumbers package? On npm I found nothing.

antonmedv commented

Yeap. This package is not done yet. =)

julianpoemp commented

@antonmedv do you have any plans creating this package? If not I would think about creating this as third-party-package

antonmedv commented

Sure. Go ahead)

  • 👍1
julianpoemp commented

@antonmedv just released codejar-linenumbers: https://github.com/julianpoemp/codejar-linenumbers . It's compatible with CodeJar >= 4

  • 🚀1
antonmedv commented

Let’s add it to readme?

  • 👍1
julianpoemp commented

@antonmedv that would be cool, yes :) I just released ngx-codejar v6 that supports CodeJar 4 with codejar-linenumbers.

  • 👍1