Duplicate IDs will cause Finder to throw an error and not return a selector

[conormaguire]

Hi there 👋

I've run into a bug where finder will throw an error if two elements on the same page have the same ID. This is the error being thrown:

finder/finder.ts

Line 69 in 1757700

throw new Error(`Selector was not found.`)

Very small reproducible example:

<h1 id="duplicate_id">This ID is not unique</h1>
<h1 id="duplicate_id" >This ID is not unique either</h1>

Maybe an unoptimized selector could be returned instead here?

[antonmedv]

Id in page should be unique. Finder checks it here:

finder/finder.ts

Line 144 in 1757700

if (unique(candidate)) {

And fails. Some workaround for non-uniq id should be implemented. Can somebody try to fix it?

[antonmedv]

Fixed! Now works with duplicates!