anup-a/svgwave

[React] [SVG] Add a slider to adjust different vertical between waves 🌊

anup-a opened this issue · 6 comments

anup-a commented

As of now there is default height for each layer of waves ( an defined in constants), the task is to add a slider input to manually change the vertical distance between the waves.

  • Fit slider in the customization Bar ( a suggestion to fit it vertically besides other sliders )
  • Remove height array from constants and change it dynamically
yashsk98 commented

Hi @anup-a,
I am relatively new to React, but this looks interesting and fun. Can I give this a whirl?

anup-a commented

@yashsk98 No problem. go ahead.
Feel free to ask if you have any questions.

  • 👍1
Remakh commented

Can anyone give this a go, or is someone assigned to/ could I assign myself?

yashsk98 commented

Hi @Remakh,
Is it alright if I try this till Sunday? If not, you can do it. Looks better than to compete and end up doing overlapping work right? Does that sound ok @anup-a ?

anup-a commented

@yashsk98 thats ok for me.

Remakh commented

@yashsk98 I already finished it lol. I've done react so it wasn't too bad. @yashsk98 @anup-a

edit: Sorry I didn't see you were already assigned. IDM if you still wanna work on it, but mine's already done so it's up to you.

  • 👍1