Export JSX version of svgs (waves)

Question

Export JSX version of svgs (waves)

quick007 opened this issue 3 years ago · 7 comments

quick007 commented 3 years ago

Hi can you please add a "copy jsx" button ty!

Answer 1 · 2021-10-09T17:20:52.000Z

@quick007 sure great idea. will put it up in the roadmap.

Answer 2 · 2021-10-09T17:23:38.000Z

Description - Right now, we support svgs and png as export option. Request is to also support the jsx version of svgs.

Answer 3 · 2021-10-11T08:25:46.000Z

@anup-a Hey, I am looking into this issue, am i allowed to add a external npm package?

Answer 4 · 2021-10-11T08:47:44.000Z

@dexterpuru hi sure. you can use npm package if it takes minimal space & effort. But I'll recommend you to just export the wave component (which we use in preview) as string. Let me know if there is any issue/ques with this approach.

Answer 5 · 2021-10-11T09:10:20.000Z

@anup-a I see that you pass the ref of whole svg tag to "Export SVG Code" component, I think converting some svg to jsx needs some parsing, i found a pkg that does the parsing, React-SVGR, check its bundle size also , let me know if i can go forward with this.

Answer 6 · 2021-10-11T21:16:28.000Z

~~If you want to do it the budget way, you could just replace all the class= to className=~~
That doesn't fix the gradient issue- nevermind.

Answer 7 · 2021-10-18T13:36:01.000Z

@dexterpuru Sorry forgot to reply to your comment.

React-svgr looks quite bulky to add in this project, I will put some time to find a better solution. Thanks