anvilresearch/connect

Server crashes if DNS lookup fails during AD/LDAP authentication request

adalinesimonian opened this issue · 0 comments

adalinesimonian commented

If DNS resolution of the AD/LDAP server name fails during an authentication request, the server crashes.

To replicate:

  1. Configure an AD/LDAP provider with an invalid hostname
  2. Try signing in using the provider

This seems related to adalinesimonian/node-adauth#1 which itself is directly a result of vesse/node-ldapauth-fork#20

My guess is that this may be temp-fixed by a try-catch block in the right place.