dedicated package name for the online variant
IzzySoft opened this issue · 19 comments
You currently provide 2 versions of your music player: one without online functionalities (for the paranoid like me 🙊), and one with online functionality (for everybody else) – which is a great idea! Unfortunately, both have the very same packageName. May I suggest to give the online variant its own unique packageName, e.g. com.atul.musicplayeronline?
Background: the combination of packageName and versionCode is a unique identifier. I've just added the offline variant to my repo (will become available here in about 2 hours from now). I'd like to add the online variant as well, but I can't – due to above mentioned restrictions: two apps cannot share the same packageName.
There's one more minor issue: your tag says v0.1 – but versionName is not 0.1, it's simply identical to versionCode. So you might wish to adjust either versionName or tag name with future releases 😉
Thanks, and all the best for your project! I hope you like the idea of your app being made easier discoverable through my repo (and also easier to keep updated on the user's devices). If so, be welcome using this badge to link there from your Readme. If you wish, your app could also be brought to F-Droid.orgs own repo, which has more prestige (and higher trust) than mine.
The thought of changing the package name crossed my mind too everytime during testing.
I will change the package name and the version code too. And yes it can be on your repo
Great, thanks! Please drop me a note here when the changed version is available and I'll pick it up then.
PS: with a different packageName, versionCode and versionName can of course be identical as it's the combination of the two that makes the "unique key" for the APK (currently: com.atul.musicplayerlite_1.apk).
I have updated the version codes and made a new release, let me know any more changes or anything you would like to see in upcoming updates. 😊
Looks perfect, thanks! And you've even integrated the badge for both, wonderful!! The new one should lead to the expected details in about 3.5h from now with the next sync. I've also pulled the update for the offline version manually (as my updater would fail, thinking "I have 1, which is higher than 0.2"). Future updates should work fine, and be pulled within 24h of your attaching them to new tags.
PS: If you wish, I can make a PR sending you the metadata in Fastlane structure. That way you could control description, screenshots etc. and changes would be pulled along with the updates. Just let me know if you're interested.
Yeah sure! Something new to learn
OK, give me a few minutes then. Fastlane originally is a "one-for-all", but you essentially have 2 apps in 1 repo (different flavors, which devs usually use Triple-T for). I find Triple-T structures a bit confusing. Fastlane now also can be used for multiple flavors; you'd need to tell then how you want to deal with that (or move the pieces as you wish and let me know). My updater can deal with any location for Fastlane, so you're basically free to choose. F-Droid itself currently does not.
Going by your build.gradle I have no idea how you separate the flavors, so I leave splitting to you. My PR will hence use the default location for Fastlane, and target the offline variant. We can go on from there later.
😅 I never planned the two versions, just created separate branches and developed each the way along. I never edit the build files, learnt Android development on my own so that's that.
I will try my best to keep it organized.
Ah, well… My updater cannot deal with branches (because Github API misses some pieces for that). So we leave it with one fastlane tree fro now, differences are minimal anyway. Images are even symlinked on my end: so what I pull for lite, also appears for online. Just the full_description.txt has an additional line for the online variant (for the online feature). If you want the same description for both (and point out the difference "inline"), that would work fine as well.
PS: For formatting of full_description.txt, find some hints in my wiki. If you only plan for my repo, Markdown or HTML both work fine. If you plan for F-Droid or Play, I'd recommend what that wiki page calls "Markdown lite", as that should work for all 3 (not sure how Play deals with links, though).
Enjoy! And feel free to ask if you think you're stuck with Fastlane details. As long as it's about the structures, I guess I can help; I just never used their binaries, so I cannot help with that part (which will probably not be needed anyway).
Thanks for merging that fast! I've enabled pulling Fastlane for the "lite" variant for now. Let me know when we shall adjust something for the "online" variant, concerning summary/description.
I will let you know about it
I was thinking of having this app on f-droid as well
No prob if the inclusion criteria are met 😃 My above link concerning formatting covers that. When you think you're ready, just go ahead and open a Request For Packaging.
Congrats to the F-Droid listing, @ap-atul! I see the Readme now carries both badges – so I take it you want me to keep your app in my repo? As it's a reproducible build at F-Droid, I don't see an issue with that and will mark it "keep" if you confirm – or remove it it you prefer that 😉
Just keep it
Marked for keep then. Thanks!
Just wondering: There was no APK for the "online" variant anymore since v0.3 – is it discontinued? Shall I remove it from my repo?
I think it's better to call it discontinued. Good to remove
OK, then I'll remove it, thanks!