apace100/apoli

[Suggestion] Add a `jumping` entity condition type

Reniel80 opened this issue · 4 comments

Reniel80 commented

This Jumping condition type can be used to consume energy from a player energy system or create moves for a parkour system.

eggohito commented

I'd argue adding a key_pressed entity condition type (like Apugli's key_pressed entity condition type) instead of a jumping entity condition type since with that, it'll be more than just for detecting whether a player is pressing/holding the jump keybind and was on the ground

There is also not really an indicator for whether a player is jumping apart from what I've described (as far as I know), so it'll be better to have a general solution instead of a specific one (which will likely be niche)

MerchantPug commented

I'd argue adding a key_pressed entity condition type (like Apugli's key_pressed entity condition type) instead of a jumping entity condition type since with that, it'll be more than just for detecting whether a player is pressing/holding the jump keybind and was on the ground

There is also not really an indicator for whether a player is jumping apart from what I've described (as far as I know), so it'll be better to have a general solution instead of a specific one (which will likely be niche)

Sooo, shall I PR Key Press optimisations as well as that condition? (We need to not be sending packets as often for this)

Reniel80 commented

Indeed.. a key_pressed entity condition type is perfect.

eggohito commented

I'd argue adding a key_pressed entity condition type (like Apugli's key_pressed entity condition type) instead of a jumping entity condition type since with that, it'll be more than just for detecting whether a player is pressing/holding the jump keybind and was on the ground
There is also not really an indicator for whether a player is jumping apart from what I've described (as far as I know), so it'll be better to have a general solution instead of a specific one (which will likely be niche)

Sooo, shall I PR Key Press optimisations as well as that condition? (We need to not be sending packets as often for this)

That would be awesome. No pressure though, especially since the packet issue is a bit tough to figure out (which is also why I haven't added eggolib's in_screen and perspective entity condition types yet)