apace100/apoli

Incompatible with Emotecraft

Closed this issue · 4 comments

KosmX commented

In LivingEntityRenderer, both mods are using the same redirect opportunity

apoli redirect

apoli/src/main/java/io/github/apace100/apoli/mixin/LivingEntityRendererMixin.java

Line 59 in 434a118

@Redirect(method = "render", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/render/entity/feature/FeatureRenderer;render(Lnet/minecraft/client/util/math/MatrixStack;Lnet/minecraft/client/render/VertexConsumerProvider;ILnet/minecraft/entity/Entity;FFFFFF)V"))

emotes redirect
https://github.com/KosmX/emotes/blob/0487d21c85d3e2b6503e8944a52d7f1b6cbf7bb2/17/fabric/src/main/java/io/github/kosmx/emotes/fabric/mixin/LivingEntityRenderRedirect.java#L26

KosmX commented

Issue in emotes repo
KosmX/emotes#181

KosmX commented

I could target Iterator.next.
And solve the issue for now.

KosmX commented

In theory, I did a workaround by targeting Iterator
But there should be a better way for this.

MerchantPug commented

This has been long fixed, and the redirect doesn't even exist anymore thanks to Mixin Extras!

Could we please close this issue?