apache/accumulo

Out of date comment in TabletServerMetricsUtil

Closed this issue · 3 comments

Describe the bug
TabletServerMetricsUtil javadoc mentions Hadoop metrics2 which we no longer use. This comment should be updated.

/**
* Wrapper around extracting metrics from a TabletServer instance
*
* Necessary to support both old custom JMX metrics and Hadoop Metrics2
*/

Versions (OS, Maven, Java, and others, as appropriate):

  • Affected version(s) of this project: 2.1.2 and up

Did a quick search and found these mentions of hadoop metrics2 as well:

MANAGER_FATE_METRICS_ENABLED("manager.fate.metrics.enabled", "true", PropertyType.BOOLEAN,
"Enable reporting of FATE metrics in JMX (and logging with Hadoop Metrics2).", "1.9.3"),

GC_METRICS_ENABLED("gc.metrics.enabled", "true", PropertyType.BOOLEAN,
"Enable detailed gc metrics reporting with hadoop metrics.", "1.10.0"),

These could probably all be fixed in one PR

MANAGER_FATE_METRICS_ENABLED and MANAGER_FATE_METRICS_ENABLED Look like they are unused and have been marked deprecated. If so, maybe they can be removed?

Fixed by #4503