Conditional writer creation does not always use client properties.

Question

Conditional writer creation does not always use client properties.

keith-turner opened this issue 3 months ago · 3 comments

Describe the bug

When creating a conditional writer with this method accumulo client properties will not be used to create the config object. When creating a conditional writer with this method client properties are used by config.merge(getConditionalWriterConfig()).

Expected behavior
Both methods for creating a conditional writer use an client properties set.

Could create an IT that does the following to test the fix for this.

Create AccumuloClient w/ all condition writer props set
Create conditional writers using the AccumuloClient. Test both methods that create a conditional writer.
cast the ConditionalWriter to ConditionalWriterImpl and get its config object and verify it has the expected things set from Accumulo props.

Answer 1 · 2024-06-26T20:14:45.000Z

Noticed this bug by running ComprehensiveIT and looking at ClientContext coverage data using #4704.

Answer 2 · 2024-06-26T20:15:27.000Z

This fix could be done 2.1.3, but it does not need to hold up 2.1.3 which is why I placed it in 2.1.4

Answer 3 · 2024-07-08T22:34:28.000Z

I can work on this