Quickstart: not having `virtualenv` installed results in broken DAGs
merobi-hub opened this issue · 5 comments
Error-free installation of Airflow using the Quickstart seems to require virtualenv, but there is no mention of this in the guide.
The following example DAGs have the dependency:
- example_branch_operator_decorator
- example_branch_operator
Yep would be good to add it - I think it make sense to add mentioning somewhere that you need to install airflow[virtualenv] extra for those somewhere. Where do you think coming as someone who wants to use it would be a good place ? Would you phrase it properly and explain it ? It's as easy as finding the right page and clicking "Suggest a change on this page" button and PR will open automatically, so if you think you can improve it - go for it.
I dont think it is the best idea,
The Quickstart talked about how to "run" directly to airflow I dont know if this is a good idea to add it to Quickstart just for those two examples only, it's like adding it as a dependency while installing the package but using it just in two examples, I think add it to quickstart as a note or add it as dependency is just the same
maybe the better idea is to add it to the specific example docstring
The problem is that those examples are there, and they will fail to import resulting in red nasty errors as you see when you enable exampes. That's a bad first-encounter with Airflow and you will look for errorrs.
Better solution indeed could be to not fail those examples i.e. add conditional code that will skip DAG creation from examples when virtualenv is not available. That would be the best option.
The problem is that those examples are there, and they will fail to import resulting in red nasty errors as you see when you enable exampes. That's a bad first-encounter with Airflow and you will look for errorrs.
Better solution indeed could be to not fail those examples i.e. add conditional code that will skip DAG creation from examples when virtualenv is not available. That would be the best option.
@potiuk could you assign it to me? Thanks
assigned.