Release files are different than the ones in the OCI helm registry.
koshrf opened this issue · 0 comments
The file:
templates/service-gateway.yaml is different from the one in the release files downloaded from github.
For example externalTrafficPolicy doesn't work as intended when not using LoadBalancer/NodePort and it gives an error:
Error: INSTALLATION FAILED: 1 error occurred: * Service "apisix-gateway" is invalid: spec.externalTrafficPolicy: Invalid value: "Local": may only be set when
type is 'NodePort' or 'LoadBalancer'
Because the 2 template files are different, in this case this part:
31,37c30,34
<-- GitHub Release version -->
< type: {{ .Values.gateway.type }}
< {{- if or (eq .Values.gateway.type "LoadBalancer") (eq .Values.gateway.type "NodePort") }}
< externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
< {{- end }}
< {{- if eq .Values.gateway.type "LoadBalancer" }}
< {{- if .Values.gateway.loadBalancerIP }}
< loadBalancerIP: {{ .Values.gateway.loadBalancerIP }}
---
<-- helm repo-->
> type: {{ .Values.service.type }}
> externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
> {{- if eq .Values.service.type "LoadBalancer" }}
> {{- if .Values.service.loadBalancerIP }}
> loadBalancerIP: {{ .Values.service.loadBalancerIP }}
39c36
I haven't checked the other files but it seems the OCI Registry https://apache.github.io/apisix-helm-chart have different version of files regardless of the version it uses. Making it harder to use it and the need to download the release every single time instead of using the OCI Registry, something is wrong when creating the new versions for helm registry.
how to reproduce?
helm repo add apisix https://apache.github.io/apisix-helm-chart
helm repo update
helm pull apisix/apisix
Download the github release (any version that is on par with the registry)
Compare the files, they are different.