Introduce Mypy in pre-commit

Question

Introduce Mypy in pre-commit

Opened this issue 4 years ago · 3 comments

michalslowikowski00 commented 4 years ago

Description
Add Mypy in pre-commit.
https://mypy.readthedocs.io/en/stable/

Use case
We would like to keep our code clean and tidy -- that's why setting up Mypy in pre-commit is a good idea.

Related Issues
N/A

Answer 1 · 2020-10-25T17:00:54.000Z

+1 for this and I think @Humbedooh also likes the type hints!

Answer 2 · 2020-10-25T17:16:15.000Z

What do you think about flake8 also?

Answer 3 · 2020-10-25T17:23:36.000Z

I think that if we introduce pylint #55 then we don't need flake8. We are also using black and flake8 is not always ok with black formatting - and it doesn't format the code automatically 😉