NullRefException from shutdown in 2.0.16
erikmav opened this issue · 11 comments
This commit introduced after 2.0.15 results in an NRE during some shutdown cases where m_lockingModel is null during Close/Dispose.
The simplistic fix is to add a check to FileAppender. The better fix is to enable nullability on FileAppender, RollingFileAppender, and their unit tests, and fix all nullability problems.
A fix is needed as a 2.0.17 package in addition to the proposed 3.0 package.
Thanks for reporting.
I will take a look.
I'm putting together a large PR with the nullability setting change. It's a lot to review so for faster release it's probably better to fix the dispose case as a quick fix then ship 2.0.17.
@erikmav I agree. Please rebase/start your nullability PR on Feature/111-Dropping-support-for-older-runtimes.
Will you provide the quick fix or should I do?
Can you add the quick fix? I'm heads-down on the large PR.
@FreeAndNil Small and large PRs posted.
Will be fixed in 2.0.17 (2024-03-22).
Hi @FreeAndNil any ETA when 2.0.17 stable version is going to be released? I need some changed from 2.0.16 but don't want to upgrade without this hotfix.
@andreycha definitely next week.
@FreeAndNil thanks a lot!