Documentation: Go 1.7 is no longer suitable for building CI

Question

Documentation: Go 1.7 is no longer suitable for building CI

de-nordic opened this issue 5 years ago · 7 comments

Regarding "Command line tool" paragraph;

Due to changes applied with
apache/mynewt-newt@6a51e35, which is usage of ProcessState.ExitCode(), in newt/util.go, the minimal requirement for go compiler is now version 1.11.1.

Answer 1 · 2019-10-04T10:05:42.000Z

I think it already required a minimum version of 1.12 because of this: apache/mynewt-newt@53f9e0c

Answer 2 · 2019-10-04T10:12:57.000Z

@de-nordic Ah, you can probably disregard my comment, mynewt-mcumgr-cli depends only on newt/util so the version you mentioned seems correct.

Answer 3 · 2019-10-04T10:15:44.000Z

Might be, I have built go from the top of master at that point (27fc32ff01) for the purpose of building the tool, so I have been far beyond 1.11.1 anyway during build; I have tracked missing feature to be included within go 11.1.1, since the version mentioned.

Answer 4 · 2020-11-16T10:30:05.000Z

Seems at least 1.12 is needed becasue of os.ProcessState getting:

src/mynewt.apache.org/newt/util/util.go:498:10: state.ExitCode undefined (type *os.ProcessState has no field or method ExitCode)

With 1.11.6

Answer 5 · 2021-03-22T09:26:19.000Z

The README.md still mentions:

The command line tool requires Go 1.7 or later.

Is this the only place where this information is out-of-date?

Answer 6 · 2021-09-09T12:40:52.000Z

I want to work on this issue

Answer 7 · 2021-09-23T13:38:19.000Z

i have made changes merge if you are satisfied and tell me if any I can help you with.