apache/pulsar-client-node

[feature request] Support batch receive and ack

shibd opened this issue · 5 comments

shibd commented

Motivation

You can refer to PIP-38.

Solution

We already support batch receive in the C++ client apache/pulsar-client-cpp#21, In the Node.js client side, we can wrap its interface for support.

mguay22 commented

Hi @shibd - was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

I was thinking the implementation would follow a similar pattern of calling methods found there in https://github.com/apache/pulsar-client-node/blob/master/src/Consumer.cc - am I completely off the mark?

Also would this implementation still require the use of ConsumerReceiveWorker? Thanks

HasanHaghniya commented

any updates?

shibd commented

was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

Yes, we need to support the batch receive method on the c interface first.

  • 👍1
  • ❤️1
samwaterbury commented

I saw that #357 was merged — I'm curious when the next release of the Nodejs Pulsar client might be? Or is there an outstanding todo for batch receive?

Thanks for all your contributions. 🙂

  • 👀1
mguay22 commented

Looks like this just landed in v1.10.0. Thank you! We're eager to try it out and see performance benefits from the batching.

  • 👍2
  • 🎉1