deck.gl Scatterplot NaN legend for TEXT/STRING column

[mona-mk]

Legend is shown as NaN in deck.gl scatter plot when TEXT or STRING column data type is selected as point color.

1. Geneate a deck.gl plot
2. Under point color, pick a TEXT or STRING column
3. See NaN as legend

Environment:

• superset version: 1.2.0

[fcomuniz]

Same issue here

[colorzhang]

tried today. same issue.

[villebro]

Would it be possible to add some more context? (redacted of course)

• Screenshots of the Explore view, especially the critical parts of the control panel
• Screenshots of the data panel (both results and samples)
• Expected result in the legend based on the data based on what's visible in the screenshots

Point being, by making the problem as easy to reproduce as possible, the community can focus developer time on working on the fix as opposed to reproducing the bug.

[mona-mk]

Thanks Ville. Further (easier) description on how to reproduce:

1. Open deck.gl Demo dashboard
2. On Scatterplot demo, click on three vertical dots on the right corner and select View chart in Explore
3. Under point color, select a TEXT dimension (in screen shot I randomly picked STREET)
4. You will see NaN in legend

Of course this is a dummy example, but hopefully will clarify the problem. Please see the requested screen shots enclosed. Expected result in this case is seeing the street names in legend, i.e. based on Data screen shot:

• Fulton Street
• Mason Street
• Hyde Street
• ....
  Also, changing the formatting to Original value doesn't help.

[villebro]

Hi @mona-mk , I was able to reproduce and was able to come up with a quick fix (I also fixed the broken tooltip at the same time):

I'll clean up the PR and open it in a sec

[villebro]

@mona-mk here's the fix PR: apache-superset/superset-ui-plugins-deckgl#43

[villebro]

@mona-mk @fcomuniz @colorzhang this is now fixed on master, feel free to try it out at your convenience

[fcomuniz]

thanks!

[mona-mk]

Thanks you very much Ville! Just pulled the latest-dev image and tested. Confirm it works as it should.

[Deninc]

@mona-mk @fcomuniz @colorzhang this is now fixed on master, feel free to try it out at your convenience

How do I check when this is merged into the official release?

[mona-mk]

@villebro today I pulled 1.3.0 and 1.3.1 images, and I still have this bug. Isn't it already included in one of the official releases?

[villebro]

@mona-mk unfortunately due to our current multirepo setup, it's very difficult to cherrypick viz plugin fixes into official Apache releases after a release branch has been cut. But we should be cutting the 1.4 branch very soon, so if you can wait just a little while longer it will be included in an official release.

[mona-mk]

Thanks a lot Ville for your update. I would appreciate if we could get it released soon. Looking forward to it 🙏

[MichaelTiemannOSC]

Just hit this myself.