apauley/hledger-flow

Windows: the preprocess and construct scripts are not executed

mwesten opened this issue · 1 comments

Describe the bug
When using hledger-flow on windows the preprocess and construct scripts that are called from src\CSVImports.hs (line 70/71) cannot be called.

On Windows executable files or scripts need a file-extension, not just only an executable attribute, hence windows doesn't know what to do with the preprocess and construct scripts.
You could for example try to find a preprocess.bat and construct.bat of preprocess.py and construct.py to get these scripts to execute.

Version and Runtime Information

$ hledger-flow --version
hledger-flow 0.13.2.0 mingw32 x86_64 ghc 8.8

This is the last git version I'm running (just updated)

Desktop (please complete the following information):

  • OS: Windows10 Pro
  • Version 1909

Hi @mwesten, thanks for these reports. I do not personally have a Windows system available.

I would be happy to accept a pull request that fixes these issues if you are interested in doing it.

About this specific issue - what happens if you just name the script preprocess.bat? Will it then run the batch script on Windows even though it is called without naming an extension?