Merge README work
inducer opened this issue · 6 comments
There's a fork that supports showing a README. I would for love that functionality to be merged.
That repository contains an old version of the module. There was at that point half-baked support to include README files and the like, working only in some cases. This half-backed support was removed with commit 30337ef because it didn't make sense to keep the code around, because there is a more powerful alternative: you can use fancyindex_header or fancyindex_footer to point to an internal location, and have the internal location return the page header plus whatever you want to serve as README file, for example using the ngx_echo module. That means that providing fancyindex_header and fancyindex_footer is enough to be able to emulate the funcionality of fancyindex_readme. As a result, I am not planning to re-add support for the fancyindex_readme directive.
OK, makes sense. Could you add an example to that effect to the docs so that clowns like me don't have to keep asking?
Thanks!
I would like to consider this a fork of my repo to be honest. When I first hosted it on Github it was just purely a old tarball on wiki.nginx.org and that failed to compile.
As no one owned up to maintaining the package I fixed it for myself and kept publishing it. Too bad no one was willing to help me and instead moved on. But that's not how we work on Github.
@damm: it is true that sometimes I have not been taking care of the code as promptly as I should have, but this repository having the whole history, plus me being the original author, makes this the authoritative one. I am always happy to receive patches and openly discuss bugs and potential features (like in this issue), so please feel free to contribute constructively 🙉
@aperezdc I can only speak for when it was originally hosted on wiki.nginx.org as a tarball. There was no way to contribute back as the details were sparse.
If you recall https://web.archive.org/web/20101230025822/http://wiki.nginx.org/NgxFancyIndex and that's dated from 2010. I created the repo and put it up on Github back in 2008 as people were wanting it fixed; and no one knew how to contact the author or get updates.
Open source has been changed quite a bit by Github because a lot of developers had tarballs up for download but no real way to get anything back except a mailing list.
@damn: Well, the history is in the repo, and if you don't want to believe that adrianperez@udc.es is me, then let be it. Unfortunately I have not been able of keeping my University e-mail address since then.
You may have created a repository in 2008 at GitHub with a in imported copy of the sources at the time, yet the project existed since 2007 and I have uploaded this myself with full history (first to Gitorius, then moved it to GitHub) converting the Bazaar revision history to Git, therefore this is the repository.
Things are crystal clear by themselves, and I do not have the time nor the will to continue discussing this matter any further — so I won't.