apivideo/api.video-reactnative-live-stream

iOS: Live Stream start in mirror mode.

codal-mpawar opened this issue · 20 comments

To Reproduce
Steps to reproduce the behavior:

  1. Open the app.
  2. Start the live stream.
  3. See the camera view

Expected behavior
Always display non-mirror mode.

Screenshots
You can refer this video
here is video

Smartphone (please complete the following information):
Smartphone (please complete the following information):

Device: iPhone 11 pro max

  • iPhone OS Version: 16.2
  • Xcode version 14.2
  • Mac OS: Monterey 12.6

Additional context
"@api.video/react-native-livestream": "v1.2.3"
"react": "16.13.1",
"react-native": "0.64.2",
"react-native-orientation-locker": "^1.4.0",

@ThibaultBee Can you please check once.

@ThibaultBee Any update on this?

this behaviour is changed in the latest version only, I have checked in 1.2.1 and it was working fine.

@tarun-showday thanks for your reply.
But do you have any idea about the fix?

@MarDi66 @pfcodes @ThibaultBee Can you please update here anything. because, we are blocked due to this issue.

Hi,
We are working on lot of projects, so we might handle issues quickly.
Also, the code is open source, so you can also look at the issue to help us :)

The cameras streams are captured in mirror? All the cameras? Is that what you are saying?
Is it really this critical?

@ThibaultBee Not much critical.

You are right, We can do but you have already an idea about the code. It's taking time to fix from our side. But sure we try to fix it.

https://github.com/apivideo/api.video-ios-live-stream/blob/237da11e6aa1ac35dbe74481b0d9e4ed6a7b5832/Sources/ApiVideoLiveStream/ApiVideoLiveStream.swift#L295

@ThibaultBee Can you please uncomment this code and it's works well. We not have permission to create PR against that. So can you please check and try to publish.

The reason I comment it is because the native library has changed its behaviours:
now:

  • the camera has changed
  • mirror the view
    (before you could do the opposite)
    So the application user will see the transition between the non mirror to mirror.

Are you okay with that?

If it's the case, Then @ThibaultBee Can we add a boolean condition for mirror mode and nonmirror mode? So in that case client decide in which mode stream needs to be displayed. Let me know what're your thoughts.

Not fond of adding a flag to fix an issue in the sublibrary.
I hope this will fix it: shogo4405/HaishinKit.swift@18132ec

@ThibaultBee May be its work, Can you update our package.

@ThibaultBee We are waiting for your response.

Any update ?

I push new HaishinKit version to the main branch.
Could you check it is fixed?

@ThibaultBee working fine. please publish the repo. thanks for your efforts.

@ThibaultBee Can you please publish the repo?
Thanks

@ThibaultBee I am closing this issue. please publish the repo ASAP.

@ThibaultBee Reminder for publish the latest code repo.