[Feat]: Unpublish stream

Question

[Feat]: Unpublish stream

Opened this issue 5 months ago · 29 comments

talhatsk commented 5 months ago

Version

2.0.0

Environment that reproduces the issue

Device iPhone xs max iOS 16.1

Use case description

Currently, the stop() method disconnects the stream but doesn't unpublish it from the server. How can we unpublish the stream?

Proposed solution

There should be a method to unpublish the stream from server as well.

Alternative solutions

No response

Answer 1 · 2024-05-15T14:03:24.000Z

Hi,

I guess you are talking about RTMP Command message. I don't think there is an official unpublish message. Which command message do you have in mind? (FCUnpublish, closeStream?)

I am just curious, what server do you use? Because if the connection is closed. There is no need to explicit unpublish.

Do you have the same issue with Android?

Answer 2 · 2024-05-15T14:47:04.000Z

Hi,

I guess you are talking about RTMP Command message. I don't think there is an official unpublish message. Which command message do you have in mind? (FCUnpublish, closeStream?)

I am just curious, what server do you use? Because if the connection is closed. There is no need to explicit unpublish.

Do you have the same issue with Android?

its FCUnpublish command. so what happen is if the stream gets unpublished then we get webhooks from rtmp server and if we close the stream (which is happening right now), webhooks won't be triggered and we have to wait for the timeout.
Can we get any method which can send FCUnpublish command

Answer 3 · 2024-05-15T14:49:05.000Z

Hi,

I guess you are talking about RTMP Command message. I don't think there is an official unpublish message. Which command message do you have in mind? (FCUnpublish, closeStream?)

I am just curious, what server do you use? Because if the connection is closed. There is no need to explicit unpublish.

Do you have the same issue with Android?

and yes it is same for android

Answer 4 · 2024-05-16T07:23:10.000Z

Hi,
I guess you are talking about RTMP Command message. I don't think there is an official unpublish message. Which command message do you have in mind? (FCUnpublish, closeStream?)
I am just curious, what server do you use? Because if the connection is closed. There is no need to explicit unpublish.
Do you have the same issue with Android?

its FCUnpublish command. so what happen is if the stream gets unpublished then we get webhooks from rtmp server and if we close the stream (which is happening right now), webhooks won't be triggered and we have to wait for the timeout. Can we get any method which can send FCUnpublish command

If the connection between the device and your server is lost, you won't get a FCUnpublish and your webhooks won't be triggered. In that case, you will face the same issue and there is nothing we can do about it.

Answer 5 · 2024-05-16T07:45:58.000Z

Hi,
I guess you are talking about RTMP Command message. I don't think there is an official unpublish message. Which command message do you have in mind? (FCUnpublish, closeStream?)
I am just curious, what server do you use? Because if the connection is closed. There is no need to explicit unpublish.
Do you have the same issue with Android?

its FCUnpublish command. so what happen is if the stream gets unpublished then we get webhooks from rtmp server and if we close the stream (which is happening right now), webhooks won't be triggered and we have to wait for the timeout. Can we get any method which can send FCUnpublish command

If the connection between the device and your server is lost, you won't get a FCUnpublish and your webhooks won't be triggered. In that case, you will face the same issue and there is nothing we can do about it.

Yes that is ok, network outage may occur or peer disconnections. But that is usually rare.
But we need intentional control to unpublish our stream to complete the flow.
So a method would be good enough to unpublish stream along with existing closing stream

Answer 6 · 2024-05-16T11:31:51.000Z

Hi,

For the implementation, I would rather like that stopStream calls FCUnpublish automatically instead of adding a specific method.

Answer 7 · 2024-05-16T11:41:55.000Z

Hi,

For the implementation, I would rather like that stopStream calls FCUnpublish automatically instead of adding a specific method.

Yes, that would also work

Answer 8 · 2024-05-23T07:59:10.000Z

I made a fix in the Android library.
Could you have a look at HaishinKit.swift (the iOS library)?

Answer 9 · 2024-05-23T09:35:30.000Z

HaishinKit.swift

it checks FCUnpublish to send a call to server to unpublish
if let fcPublishName { connection.call("FCUnpublish", responder: nil, arguments: fcPublishName) }

Answer 10 · 2024-06-10T08:22:49.000Z

Just to confirm. The argument in the FCUnpublish is going to be the provided StreamKey.
Is it what you expect?

Answer 11 · 2024-06-10T09:44:26.000Z

Just to confirm. The argument in the FCUnpublish is going to be the provided StreamKey. Is it what you expect?

yes thats correct

Answer 12 · 2024-06-10T13:39:19.000Z

Could you test the iOS version of the main branch?

Answer 13 · 2024-06-10T15:04:35.000Z

Could you test the iOS version of the main branch?

sure, i have to test the example folder on the main branch?

Answer 14 · 2024-06-10T15:14:40.000Z

Yes Please :)
You can run:

yarn && yarn example ios

Answer 15 · 2024-06-11T13:37:55.000Z

Could you test the iOS version of the main branch?

so i've tested the main branch code, unfortunately its behaving the same way as before. I'm not getting any webhooks fired as it should be on the call of unpublish. The patchset is not working i guess.

Answer 16 · 2024-06-11T14:51:34.000Z

hmm.
I can see FCUnpublish in Wireshark in the iOS example.
See:

Answer 17 · 2024-06-12T05:52:16.000Z

Hi there,

I was testing the main branch as well. The FCUnpublish() followed by closeStream() does not delete the stream properly from rtmp server. RTMP server reports connection closed by peerdue to closeStream() which is not the intended effect. In term of unpublishing the stream FCUnpublish command must be followed by deleteStream() command.

Here is the packet captured from OBS while starting and stopping.

Can you provide an updated build with above modification.

Answer 18 · 2024-06-12T07:13:33.000Z

@ThibaultBee I guess that must be the issue, closeStream() is not killing the stream properly. can we replace or add deleteStream()?

Answer 19 · 2024-06-12T07:34:39.000Z

Could you add an issue for this in HaishinKit?

Answer 20 · 2024-06-12T08:23:17.000Z

FCUnpublish() followed by closeStream()

reported. Link

Answer 21 · 2024-07-12T09:22:26.000Z

Could you test the android version on main branch?

Answer 22 · 2024-07-23T07:13:08.000Z

Have you made any progress on the iOS part?

Answer 23 · 2024-07-24T09:55:35.000Z

Have you made any progress on the iOS part?

it is in progress yet.

Answer 24 · 2024-07-29T07:15:54.000Z

Have you made any progress on the iOS part?

@ThibaultBee PR is up for iOS haishinkit

Answer 25 · 2024-07-30T08:18:17.000Z

Have you made any progress on the iOS part?

deleteStream PR is merged @ThibaultBee. You can integrate it in the package now.

Answer 26 · 2024-08-08T13:31:12.000Z

Waiting for next HK release

Answer 27 · 2024-08-26T14:20:36.000Z

Have you test the fix made for Android?

Answer 28 · 2024-09-11T09:18:01.000Z

Release 2.0.1 is made with HK 1.9.3 that should fix this.

Answer 29 · 2024-09-11T09:19:16.000Z

Could you test on 2.0.1?