apollo-server-integrations/apollo-server-integration-next

Don't require a change set for Changesets and Renovate's pull requests

Closed this issue · 3 comments

martinnabhan commented

Changesets and Renovate's pull requests' checks fail due to missing change sets. Since we don't need to add change sets for these changes we shouldn't run changeset status on branches starting with changeset-release/ or renovate/. Might also be good to enable auto merge, like https://github.com/apollographql/apollo-server seems to be doing.

martinnabhan commented

#43 worked when I tried it out locally but doesn't seem to work after merging so I'm reopening this.
https://github.com/apollo-server-integrations/apollo-server-integration-next/actions/runs/3475492524/jobs/5809777768

trevor-scheer commented

We accomplish this in the server repo by conditionally running the Circle job, is there a GH action equivalent you can try?

  Changesets:
    docker:
    - image: cimg/base:stable
    steps:
      - run: echo Ensure there is at least one step
      - unless:
          condition:
            matches:
              pattern: "^changeset-release/.+$"
              value: << pipeline.git.branch >>
          steps:
            - setup-node
            - run: npm run changeset-check
martinnabhan commented

Thank you! I was thinking about going that route, but I wanted the change set check to run both locally (when running npm run check) and on CI. I'll tinker a bit with the shell script and if it gets too convoluted I'll separate the change set check into a separate GitHub Actions job.

  • 👍1