Make past events really past events
Closed this issue · 7 comments
When the upcoming cursor filter is set to false, right not it does a $lte comparison in the mongo cursor. It makes more sense to me (and a client bringing this up) that past events would not include today's events. I'd switch that $lte to $lt in a future major release.
https://github.com/apostrophecms/apostrophe-events/blob/master/lib/cursor.js#L47
If an event happened at 9am today and ended at 10am and it's now 1pm it is a past event.
But it is also current-ish.
The attitude has been not to be too picky so users get everything they might intend. Open to discussion of course. Curious what @carlykaras thinks.
Listing an event as both past and upcoming is the confusing bit right now. Listing all of today's events with other upcoming events seems less so, assuming times are displayed somehow to clarify further.
I'd also be for including time in this as well to have more exact determination. Time zones need to be dealt with, but this isn't the hardest case as that goes.
We could add a bit of padding to the time, I agree with both of your points. Maybe an event becomes a past event at the end of that day?
Not sure what you mean about padding the time, @carlykaras.
Choosing specific hour padding sounds overly opinionated for the module. If we want to include time we should just be as exact as possible. I don't think that's unreasonable, but it's also a bigger change from the current implementation.
From your previous comment ("Maybe an event becomes a past event at the end of that day?") if we're not using time of day then I'm going to still suggest we make events only past once the day is done. That way we don't have Schrödinger's event, both upcoming and past.