"name" option of apostrophe-events-pages is hardcoded, breaking subclasses unless they are explicitly configured

[boutell]

If you’re wondering why your events pages for modules that extend apostrophe-events-pages under a new name never work, this is why.

apostrophe-events-pages eventually inherits from apostrophe-custom-pages, which does this for you. But it's hardcoded as the name option of apostrophe-events-pages, breaking the magic.

If we fix it in 2.x, it’ll be a bc break for people who extended it but decided to just live with this weird fact and have only one module that extends it and put apostrophe-events-page in their apostrophe-pages configuration.

And in fact we have done that ourselves.

Which means we have to keep explicitly putting name options in our subclasses of apostrophe-events-pages until 3.0.

Dang.