apozas/contactdiary

[Bug] Since version 1.4.7, the "make a copy today"-button is missing

Closed this issue · 5 comments

Description of the bug
Since upgrading to version 1.4.7, the "make a copy today"-button (and the delete button) in the top right corner of the edit view are missing. It's easier to access than the menu entry (long vs short press), so I don't think it should be removed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new entry
  2. Click on it
  3. See no buttons in the top right corner

Expected behavior
I expect to see two buttons in the top right corner, one for "make a copy today", and one for "delete".

Screenshots

System information (please complete the following information):

  • Device: Samsung Galaxy A5 (SM-A520F)
  • Android version: 9
  • OS: LineageOS 16.0
  • App version 1.4.7

Additional context
Feel free to ask for any other info you might need!

Thank you very much for noticing this. The removal was not intended, so I will fix it and release a new version soon (all things going well, before the end of the week).

I think this issue is originated with f6ef1db.
I did not notice there where these buttons on the edit screens.
@apozas let me know if I can help.

I believe that may be the case, indeed. I remember myself thinking on how to avoid using so many "same" layouts a few months ago, and there must had been a reason why my previous me didn't do it straight away xD. This is nevertheless a good excuse for me to find a more elegant solution. I will work on it today, and if I don't find an easy way I will just revert the changes. Thanks for your offering!

You can play with the Visibility attribute from the activities to avoid multiple layouts.

Well, it seems like 5f42ebc should fix the issue (at least it does for me). In the end it is playing with Visibilityes, so it's a much more elegant solution than what I had before. Thank you both!