withSpan() doesn’t work as documented

Question

JensAyton opened this issue 4 years ago · 2 comments

The documentation comments clearly state:

DO NOT end() the passed in span manually. It will be ended automatically when the function returns.

However, there is no end() on the happy path, only if an error occurs.

Of course I could make a PR, but when I encountered this I convinced myself that such an obvious omission might be intentional. :-)

Answer 1 · 2020-12-14T10:37:52.000Z

Thanks for spotting this! Bug indeed 🐞

Answer 2 · 2020-12-14T10:42:33.000Z

Of course I could make a PR
@JensAyton

Thanks for the bug report! Would you like to take this on yourself?