appliedsec/pygeoip

no isp_by_? methods

JakeAustwick opened this issue · 6 comments

It seems there are no isp_by_... methods defined as stated in the docs.

http://pygeoip.readthedocs.org/en/latest/getting-started.html

AttributeError: 'GeoIP' object has no attribute 'isp_by_addr'

Any ideas?

We just recently switched documentation to Sphinx and readthedocs.org, so therefore we only have documentation for version 0.3.1 which is still not released. Older versions can't generate the same type of documentation.

isp_by_addr is an alias for org_by_addr, so try that instead in your version.

We're in the progress towards releasing 0.3.1 now and building separate docs for master and v0.3.1. This will resolve these issues.

Documentation can now be found using the git tag from 0.3.1 and up:

http://pygeoip.readthedocs.org/en/v0.3.1/
http://pygeoip.readthedocs.org/en/master/

Hey,

Thanks. I figured it was a docs issue, however you state that ISP is just an alias for ORGs?

How does that work? They're separate things with different databases from MaxMind afaik ?

Organisation, ISP and ASNUM databases are all constructed in the same way and they just return a string. So org_by_addr will fetch the correct data with your ISP database.

Alright, that solves everything. Thanks!